[pycodestyle] Add fix for multiple-imports-on-one-line (E401)
#9518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diceroll123
force-pushed
the
add-autofix-for-E401
branch
2 times, most recently
from
7b3b35e to
69f71d2
Compare
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| E401 | 2 | 0 | 0 | 2 | 0 |
| diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement( | ||
| replacement, | ||
| stmt.range(), | ||
| ))); |
There was a problem hiding this comment.
Can you add test cases for, e.g.:
x = 1; import re as regex, string
import re as regex, string; x = 1
CodSpeed Performance ReportMerging #9518 will not alter performanceComparing Summary
|
diceroll123
force-pushed
the
add-autofix-for-E401
branch
from
b387a6e to
0477953
Compare
charliermarsh
added
fixes
charliermarsh
changed the title
pycodestyle] - add fix for multiple_imports_on_one_line (E401)pycodestyle] Add fix for multiple-imports-on-one-line (E401)
charliermarsh
approved these changes
Jan 21, 2024
| }) | ||
| .join("; "); | ||
|
|
||
| Fix::safe_edit(Edit::range_replacement(replacement, stmt.range())) |
There was a problem hiding this comment.
@diceroll123 - I decided to just ; -join these for now, since it's hard to know if we're allowed to split them.
auto-merge was automatically disabled
January 21, 2024 20:02
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add autofix for
multiple_imports_on_one_line,E401Test Plan
cargo test