Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-simplify] Avoid some more enumerate-for-loop false positives (SIM113) #9515

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

charliermarsh
Copy link
Member

Avoids, e.g., this false positive from the ecosystem check.

@charliermarsh charliermarsh added the bug Something isn't working label Jan 14, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -3 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

zulip/zulip (+0 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

- zerver/data_import/slack.py:634:9: SIM113 Use `enumerate()` for index variable `recipient_id_count` in `for` loop
- zerver/data_import/slack.py:635:9: SIM113 Use `enumerate()` for index variable `subscription_id_count` in `for` loop
- zilencer/management/commands/populate_db.py:705:17: SIM113 Use `enumerate()` for index variable `i` in `for` loop

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
SIM113 3 0 3 0 0

@charliermarsh charliermarsh merged commit 953d48b into main Jan 14, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/local branch January 14, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant