Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homogenize PLR0914 message to match other PLR 09XX rules and pylint message #9399

Merged
merged 2 commits into from
Jan 5, 2024
Merged

homogenize PLR0914 message to match other PLR 09XX rules and pylint message #9399

merged 2 commits into from
Jan 5, 2024

Conversation

mikaelarguedas
Copy link
Contributor

Similar to #9308 for PLR0914

Summary

Test Plan

cargo test / cargo insta review

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+290 -290 violations, +0 -0 fixes in 10 projects; 33 projects unchanged)

apache/airflow (+37 -37 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

+ airflow/cli/commands/kubernetes_command.py:77:5: PLR0914 Too many local variables (17/15)
- airflow/cli/commands/kubernetes_command.py:77:5: PLR0914 Too many local variables: (17/15)
+ airflow/dag_processing/processor.py:420:9: PLR0914 Too many local variables (21/15)
- airflow/dag_processing/processor.py:420:9: PLR0914 Too many local variables: (21/15)
+ airflow/io/path.py:96:9: PLR0914 Too many local variables (16/15)
- airflow/io/path.py:96:9: PLR0914 Too many local variables: (16/15)
+ airflow/jobs/backfill_job_runner.py:876:9: PLR0914 Too many local variables (16/15)
- airflow/jobs/backfill_job_runner.py:876:9: PLR0914 Too many local variables: (16/15)
+ airflow/jobs/scheduler_job_runner.py:294:9: PLR0914 Too many local variables (35/15)
- airflow/jobs/scheduler_job_runner.py:294:9: PLR0914 Too many local variables: (35/15)
... 64 additional changes omitted for project

aws/aws-sam-cli (+20 -20 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ samcli/commands/deploy/guided_context.py:108:9: PLR0914 Too many local variables (20/15)
- samcli/commands/deploy/guided_context.py:108:9: PLR0914 Too many local variables: (20/15)
+ samcli/commands/init/interactive_init_flow.py:213:5: PLR0914 Too many local variables (29/15)
- samcli/commands/init/interactive_init_flow.py:213:5: PLR0914 Too many local variables: (29/15)
+ samcli/commands/pipeline/bootstrap/cli.py:240:5: PLR0914 Too many local variables (23/15)
- samcli/commands/pipeline/bootstrap/cli.py:240:5: PLR0914 Too many local variables: (23/15)
+ samcli/hook_packages/terraform/hooks/prepare/translate.py:153:5: PLR0914 Too many local variables (31/15)
- samcli/hook_packages/terraform/hooks/prepare/translate.py:153:5: PLR0914 Too many local variables: (31/15)
+ samcli/lib/iac/cfn/cfn_iac.py:83:9: PLR0914 Too many local variables (21/15)
- samcli/lib/iac/cfn/cfn_iac.py:83:9: PLR0914 Too many local variables: (21/15)
... 30 additional changes omitted for project

bokeh/bokeh (+12 -12 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

+ examples/advanced/extensions/parallel_plot/parallel_plot.py:14:5: PLR0914 Too many local variables (24/15)
- examples/advanced/extensions/parallel_plot/parallel_plot.py:14:5: PLR0914 Too many local variables: (24/15)
+ examples/models/calendars.py:26:5: PLR0914 Too many local variables (21/15)
- examples/models/calendars.py:26:5: PLR0914 Too many local variables: (21/15)
+ src/bokeh/embed/bundle.py:259:5: PLR0914 Too many local variables (25/15)
- src/bokeh/embed/bundle.py:259:5: PLR0914 Too many local variables: (25/15)
+ src/bokeh/layouts.py:193:5: PLR0914 Too many local variables (22/15)
- src/bokeh/layouts.py:193:5: PLR0914 Too many local variables: (22/15)
+ src/bokeh/models/util/structure.py:226:9: PLR0914 Too many local variables (18/15)
- src/bokeh/models/util/structure.py:226:9: PLR0914 Too many local variables: (18/15)
... 14 additional changes omitted for project

freedomofpress/securedrop (+7 -7 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ securedrop/sdconfig.py:101:5: PLR0914 Too many local variables (20/15)
- securedrop/sdconfig.py:101:5: PLR0914 Too many local variables: (20/15)
+ securedrop/tests/functional/conftest.py:95:5: PLR0914 Too many local variables (18/15)
- securedrop/tests/functional/conftest.py:95:5: PLR0914 Too many local variables: (18/15)
+ securedrop/tests/test_integration.py:120:5: PLR0914 Too many local variables (18/15)
- securedrop/tests/test_integration.py:120:5: PLR0914 Too many local variables: (18/15)
+ securedrop/tests/test_integration.py:220:5: PLR0914 Too many local variables (16/15)
- securedrop/tests/test_integration.py:220:5: PLR0914 Too many local variables: (16/15)
+ securedrop/tests/test_journalist.py:3347:5: PLR0914 Too many local variables (17/15)
- securedrop/tests/test_journalist.py:3347:5: PLR0914 Too many local variables: (17/15)
... 4 additional changes omitted for project

fronzbot/blinkpy (+1 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ blinkpy/sync_module.py:285:15: PLR0914 Too many local variables (18/15)
- blinkpy/sync_module.py:285:15: PLR0914 Too many local variables: (18/15)

ibis-project/ibis (+5 -5 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ ibis/backends/bigquery/udf/core.py:524:9: PLR0914 Too many local variables (17/15)
- ibis/backends/bigquery/udf/core.py:524:9: PLR0914 Too many local variables: (17/15)
+ ibis/backends/dask/aggcontext.py:90:9: PLR0914 Too many local variables (19/15)
- ibis/backends/dask/aggcontext.py:90:9: PLR0914 Too many local variables: (19/15)
+ ibis/backends/pandas/aggcontext.py:582:9: PLR0914 Too many local variables (18/15)
- ibis/backends/pandas/aggcontext.py:582:9: PLR0914 Too many local variables: (18/15)
+ ibis/backends/pandas/execution/window.py:258:5: PLR0914 Too many local variables (16/15)
- ibis/backends/pandas/execution/window.py:258:5: PLR0914 Too many local variables: (16/15)
+ ibis/expr/datatypes/parse.py:54:5: PLR0914 Too many local variables (20/15)
- ibis/expr/datatypes/parse.py:54:5: PLR0914 Too many local variables: (20/15)

pandas-dev/pandas (+91 -91 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ pandas/_version.py:250:5: PLR0914 Too many local variables (17/15)
- pandas/_version.py:250:5: PLR0914 Too many local variables: (17/15)
+ pandas/core/_numba/kernels/sum_.py:65:5: PLR0914 Too many local variables (16/15)
- pandas/core/_numba/kernels/sum_.py:65:5: PLR0914 Too many local variables: (16/15)
+ pandas/core/_numba/kernels/var_.py:171:5: PLR0914 Too many local variables (16/15)
- pandas/core/_numba/kernels/var_.py:171:5: PLR0914 Too many local variables: (16/15)
+ pandas/core/_numba/kernels/var_.py:74:5: PLR0914 Too many local variables (16/15)
- pandas/core/_numba/kernels/var_.py:74:5: PLR0914 Too many local variables: (16/15)
+ pandas/core/arraylike.py:253:5: PLR0914 Too many local variables (16/15)
- pandas/core/arraylike.py:253:5: PLR0914 Too many local variables: (16/15)
+ pandas/core/arrays/datetimes.py:411:9: PLR0914 Too many local variables (16/15)
- pandas/core/arrays/datetimes.py:411:9: PLR0914 Too many local variables: (16/15)
+ pandas/core/computation/align.py:87:5: PLR0914 Too many local variables (20/15)
- pandas/core/computation/align.py:87:5: PLR0914 Too many local variables: (20/15)
+ pandas/core/frame.py:11373:9: PLR0914 Too many local variables (17/15)
... 167 additional changes omitted for project

pypa/pip (+3 -3 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ src/pip/_internal/cli/autocompletion.py:15:5: PLR0914 Too many local variables (19/15)
- src/pip/_internal/cli/autocompletion.py:15:5: PLR0914 Too many local variables: (19/15)
+ src/pip/_internal/commands/install.py:266:9: PLR0914 Too many local variables (35/15)
- src/pip/_internal/commands/install.py:266:9: PLR0914 Too many local variables: (35/15)
+ src/pip/_internal/operations/install/wheel.py:426:5: PLR0914 Too many local variables (38/15)
- src/pip/_internal/operations/install/wheel.py:426:5: PLR0914 Too many local variables: (38/15)

scikit-build/scikit-build-core (+3 -3 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

+ src/scikit_build_core/build/sdist.py:91:5: PLR0914 Too many local variables (16/15)
- src/scikit_build_core/build/sdist.py:91:5: PLR0914 Too many local variables: (16/15)
+ src/scikit_build_core/build/wheel.py:113:5: PLR0914 Too many local variables (38/15)
- src/scikit_build_core/build/wheel.py:113:5: PLR0914 Too many local variables: (38/15)
+ src/scikit_build_core/setuptools/build_cmake.py:87:9: PLR0914 Too many local variables (17/15)
- src/scikit_build_core/setuptools/build_cmake.py:87:9: PLR0914 Too many local variables: (17/15)

zulip/zulip (+111 -111 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

+ analytics/management/commands/populate_analytics_db.py:73:9: PLR0914 Too many local variables (26/15)
- analytics/management/commands/populate_analytics_db.py:73:9: PLR0914 Too many local variables: (26/15)
+ analytics/views/installation_activity.py:94:5: PLR0914 Too many local variables (16/15)
- analytics/views/installation_activity.py:94:5: PLR0914 Too many local variables: (16/15)
+ analytics/views/stats.py:250:5: PLR0914 Too many local variables (17/15)
- analytics/views/stats.py:250:5: PLR0914 Too many local variables: (17/15)
+ analytics/views/support.py:156:5: PLR0914 Too many local variables (27/15)
- analytics/views/support.py:156:5: PLR0914 Too many local variables: (27/15)
+ analytics/views/support.py:406:5: PLR0914 Too many local variables (18/15)
- analytics/views/support.py:406:5: PLR0914 Too many local variables: (18/15)
+ corporate/lib/stripe.py:1233:9: PLR0914 Too many local variables (21/15)
- corporate/lib/stripe.py:1233:9: PLR0914 Too many local variables: (21/15)
+ corporate/lib/stripe.py:1422:9: PLR0914 Too many local variables (16/15)
- corporate/lib/stripe.py:1422:9: PLR0914 Too many local variables: (16/15)
+ corporate/lib/stripe.py:1781:9: PLR0914 Too many local variables (28/15)
- corporate/lib/stripe.py:1781:9: PLR0914 Too many local variables: (28/15)
+ corporate/lib/stripe.py:1962:9: PLR0914 Too many local variables (23/15)
- corporate/lib/stripe.py:1962:9: PLR0914 Too many local variables: (23/15)
+ corporate/tests/test_stripe.py:1090:9: PLR0914 Too many local variables (19/15)
... 203 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLR0914 580 290 290 0 0

charliermarsh
charliermarsh approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@charliermarsh charliermarsh added the bug Something isn't working label Jan 5, 2024
@charliermarsh charliermarsh merged commit 59078c5 into astral-sh:main Jan 5, 2024
17 checks passed
@mikaelarguedas mikaelarguedas deleted the homogenize_PLR_err_msg_round2 branch January 5, 2024 12:33
@Porkepix Porkepix mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelarguedas @charliermarsh