Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Display for formatter parse errors #9316

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Use Display for formatter parse errors #9316

merged 1 commit into from
Dec 29, 2023

Conversation

charliermarsh
Copy link
Member

Summary

This helps a bit with (but does not close) the issues described in #9311. E.g., now, we at least see: error: Failed to format main.py: source contains syntax errors: invalid syntax. Got unexpected token '=' at byte offset 20.

@charliermarsh
Copy link
Member Author

There will be separate changes to add the row and column information.

@charliermarsh charliermarsh added the formatter Related to the formatter label Dec 29, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) December 29, 2023 22:26
@charliermarsh charliermarsh merged commit 97e9d3c into main Dec 29, 2023
16 checks passed
@charliermarsh charliermarsh added the cli Related to the command-line interface label Dec 29, 2023
@charliermarsh charliermarsh deleted the charlie/display branch December 29, 2023 22:26
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command-line interface formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant