Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid adding return types to stub methods #9277

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Avoid adding return types to stub methods #9277

merged 1 commit into from
Dec 25, 2023

Conversation

charliermarsh
Copy link
Member

We should avoid adding -> None to stubs in .pyi files, along with a few other cases. (We already ignore abstract methods.)

Closes #9270.

@charliermarsh charliermarsh added the bug Something isn't working label Dec 25, 2023
@charliermarsh charliermarsh merged commit fa78d2d into main Dec 25, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/abstract branch December 25, 2023 14:03
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

pypa/setuptools (error) 

ruff failed
  Cause: 'quote-style = preserve' is a preview only feature. Run with '--preview' to enable it.

Linter (preview)

✅ ecosystem check detected no linter changes.

@miccal miccal mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unsafe ANN autofix adds -> None to all functions in pyi files
1 participant
@charliermarsh