Enable annotation quoting for multi-line expressions #9142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given:
We currently wrap the annotation in single quotes, which leads to a syntax error:
There are a few options for what to suggest for users here... Use triple quotes:
Or, use an implicit string concatenation (which may require parentheses):
The solution I settled on here is to use the
Generator
, which effectively means we write it out on a single line, like:It's kind of the "least opinionated" solution, but it does mean we'll expand to a very long line in some cases.
Closes #9136.