Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support floating-point base in FURB163 #9100

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Support floating-point base in FURB163 #9100

merged 2 commits into from
Dec 11, 2023
+58 −8

Conversation

siiptuo
Copy link
Contributor

@siiptuo siiptuo commented Dec 11, 2023

Summary

Check floating-point numbers similarly to integers in FURB163. For example, both math.log(x, 10) and math.log(x, 10.0) should be changed to math.log10(x).

Test Plan

Added couple of test cases.

charliermarsh
charliermarsh approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit a53d59f into astral-sh:main Dec 11, 2023
17 checks passed
@charliermarsh charliermarsh added rule Implementing or modifying a lint rule bug Something isn't working and removed rule Implementing or modifying a lint rule labels Dec 11, 2023
@siiptuo siiptuo deleted the FURB163-float branch December 11, 2023 20:50
@krehel krehel mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siiptuo @charliermarsh