Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unsafe fix suggestions when explicitly disabled #9095

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Dec 11, 2023

Hides hints about unsafe fixes when they are disabled e.g. with --no-unsafe-fixes or unsafe-fixes = false. By default, unsafe fix hints are still displayed. This seems like a nice way to remove the nag for users who have chosen not to apply unsafe fixes.

Inspired by comment at #9063 (comment)

@zanieb zanieb requested a review from charliermarsh December 11, 2023 16:10
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

crates/ruff_cli/src/printer.rs Show resolved Hide resolved
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@zanieb zanieb merged commit 8e9bf84 into main Dec 11, 2023
17 checks passed
@zanieb zanieb deleted the zb/unsafe-hint-hide branch December 11, 2023 21:42
@zanieb zanieb added the cli Related to the command-line interface label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants