Detect unused-asyncio-dangling-task (RUF006) on unused assignments
#9060
Conversation
|
| else { | ||
| continue; | ||
| }; | ||
| asyncio_dangling_task(checker, value, diagnostics); |
There was a problem hiding this comment.
Nice job figuring this out.
There was a problem hiding this comment.
Can you try using typing::analyze::resolve_assignment here instead? It will also handle AnnAssign.
There was a problem hiding this comment.
Hmm, not sure how to do it without some refactoring.
I currently use assignment value expression which (if I'm not mistaken) is discarded after processing in resolve_assignment?
For now I've extended the pattern match to include AnnAssign as done in unnecessary_list_cast - but would gladly change it
charliermarsh
changed the title
unused-asyncio-dangling-task (RUF006) on unused assignments
|
I think this PR has caused ruff to start complaining even when assignments are to globals and nonlocals. Is that intentional? |
|
@hauntsaninja - probably not — if you share an example I’m happy to ensure it’s fixed in the next release. |
|
Thanks, filed #9262 ! |
Summary
Fixes #8863 : Detect asyncio-dangling-task (RUF006) when discarding return value
Test Plan
added new two testcases, changed result of an old one that was made more specific