Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-pyi] Check for kwarg and vararg NoReturn type annotations #8948

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[flake8-pyi] Check for kwarg and vararg NoReturn type annotations #8948

merged 2 commits into from
Dec 1, 2023

Conversation

tjkuson
Copy link
Contributor

@tjkuson tjkuson commented Dec 1, 2023

Summary

Triggers no-return-argument-annotation-in-stub (PYI050) for vararg and kwarg NoReturn type annotations.

Related to #8771.

Test Plan

cargo test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@tjkuson tjkuson marked this pull request as ready for review December 1, 2023 16:43
charliermarsh
charliermarsh approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Dec 1, 2023
@charliermarsh charliermarsh changed the title Check for kwarg and vararg NoReturn type annotations [flake8-pyi] Check for kwarg and vararg NoReturn type annotations Dec 1, 2023
@charliermarsh charliermarsh merged commit d66063b into astral-sh:main Dec 1, 2023
17 checks passed
@tjkuson tjkuson deleted the noreturn-false-negative branch December 1, 2023 17:20
@miccal miccal mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjkuson @charliermarsh