Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid PERF101 if there's an append in loop body #8809

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Avoid PERF101 if there's an append in loop body #8809

merged 2 commits into from
Nov 21, 2023

Conversation

dhruvmanila
Copy link
Member

Summary

Avoid PERF101 if there's an append in loop body

Test Plan

Add new test cases for this pattern.

fixes: #8746

@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@dhruvmanila dhruvmanila added the bug Something isn't working label Nov 21, 2023
@dhruvmanila dhruvmanila requested a review from zanieb November 21, 2023 16:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila requested a review from zanieb November 21, 2023 20:03
@dhruvmanila dhruvmanila merged commit 5ce6299 into main Nov 21, 2023
17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/perf101 branch November 21, 2023 21:35
@miccal miccal mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PERF101 False positive
2 participants
@dhruvmanila @zanieb