[refurb] Implement math-constant (FURB152)
#8727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Nov 16, 2023
Comment on lines
59
to
62
| Ok(Fix::unsafe_edits( | ||
| Edit::range_replacement(binding, literal.range()), | ||
| [edit], | ||
| )) |
There was a problem hiding this comment.
Most likely it changes result of calculations. For example, math.pi is more precise than 3.14.
There was a problem hiding this comment.
I'm unsure if that means we need to mark it as unsafe, I could go either way though. @charliermarsh?
If we do leave it as unsafe, we should explain why in the rule docs.
There was a problem hiding this comment.
Hah, this is an interesting case. I guess I'd lean towards unsafe since it could break tests, etc., if you had hard-coded expectations that differed slightly?
There was a problem hiding this comment.
I guess but tests written to check floating point math already should include tolerances. Idk I'm struggling to think of a case where this would change runtime behavior in a meaningful way.
There was a problem hiding this comment.
Since it's in preview, it may be fine to just use safe and see if we get feedback.
zanieb
approved these changes
Nov 16, 2023
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLW3201 | 294 | 147 | 147 | 0 | 0 |
| FURB152 | 12 | 12 | 0 | 0 | 0 |
charliermarsh
changed the title
refurb] Implement math-constant (FURB152)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements FURB152 that checks for literals that are similar to constants in
mathmodule, for example:Use instead:
Related to #1348.
Test Plan
Tested with few test cases.