-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Implementation for Pylint E1132: Repeated Keyword #8706
Conversation
|
Awesome, thanks for this PR and for getting involved! There's some overlap here with #8450, I'm almost wondering if they should one rule since they both only deal with static dictionary spreads, but I think I need to take a closer look at the code before I have a clear answer to that. |
Oh yeah! I totally did not see that other PR. I'm happy to help merge stuff if we go down that route. I also should have mentioned this in the summary, but this is my first meaningful Rust code besides random side projects, so feel free to be extra nit-picky with your comments 😄 |
Okay, it's probably fine to just proceed with this rule on its own. Left a few comments! |
@charliermarsh Okay this is ready for another pass. All of your comments should be addressed. I also updated some of my destructuring statements to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Adds the Pylint rule E1132 to check for repeated keyword arguments in a function call.
Test Plan
Tested via the included unit tests and manual spot checking.