[pycodestyle] Add E12 rules (continuation lines indentation rules)

crates/ruff_linter/src/checkers/logical_lines.rs

@@ -7,9 +7,9 @@ use ruff_text_size::{Ranged, TextRange};
 
 use crate::registry::AsRule;
 use crate::rules::pycodestyle::rules::logical_lines::{
-    extraneous_whitespace, indentation, missing_whitespace, missing_whitespace_after_keyword,
-    missing_whitespace_around_operator, space_after_comma, space_around_operator,
-    whitespace_around_keywords, whitespace_around_named_parameter_equals,
+    continuation_lines, extraneous_whitespace, indentation, missing_whitespace,
+    missing_whitespace_after_keyword, missing_whitespace_around_operator, space_after_comma,
+    space_around_operator, whitespace_around_keywords, whitespace_around_named_parameter_equals,
     whitespace_before_comment, whitespace_before_parameters, LogicalLines, TokenFlags,
 };
 use crate::settings::LinterSettings;
@@ -88,6 +88,15 @@ pub(crate) fn check_logical_lines(
 
         let indent_size = 4;
 
+        continuation_lines(
+            &mut context,
+            &line,
+            locator,
+            indent_char,
+            indent_size,
+            settings.pycodestyle.hang_closing,
+        );
+
         for kind in indentation(
             &line,
             prev_line.as_ref(),

crates/ruff_linter/src/codes.rs

@@ -81,6 +81,28 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         #[allow(deprecated)]
         (Pycodestyle, "E117") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::OverIndented),
         #[allow(deprecated)]
+        (Pycodestyle, "E121") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::UnderIndentedHangingIndent),
+        #[allow(deprecated)]
+        (Pycodestyle, "E122") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::MissingOrOutdentedIndentation),
+        #[allow(deprecated)]
+        (Pycodestyle, "E123") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::ClosingBracketNotMatchingOpeningBracketIndentation),
+        #[allow(deprecated)]
+        (Pycodestyle, "E124") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::ClosingBracketNotMatchingOpeningBracketVisualIndentation),
+        #[allow(deprecated)]
+        (Pycodestyle, "E125") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::ContinuationLineIndentSameAsNextLogicalLine),
+        #[allow(deprecated)]
+        (Pycodestyle, "E126") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::ContinuationLineOverIndentedForHangingIndent),
+        #[allow(deprecated)]
+        (Pycodestyle, "E127") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::ContinuationLineOverIndentedForVisualIndent),
+        #[allow(deprecated)]
+        (Pycodestyle, "E128") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::ContinuationLineUnderIndentedForVisualIndent),
+        #[allow(deprecated)]
+        (Pycodestyle, "E129") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::VisuallyIndentedLineWithSameIndentAsNextLogicalLine),
+        #[allow(deprecated)]
+        (Pycodestyle, "E131") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::ContinuationLineUnalignedForHangingIndent),
+        #[allow(deprecated)]
+        (Pycodestyle, "E133") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::ClosingBracketMissingIndentation),
+        #[allow(deprecated)]
         (Pycodestyle, "E201") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::WhitespaceAfterOpenBracket),
         #[allow(deprecated)]
         (Pycodestyle, "E202") => (RuleGroup::Nursery, rules::pycodestyle::rules::logical_lines::WhitespaceBeforeCloseBracket),

crates/ruff_linter/src/registry.rs

@@ -304,6 +304,17 @@ impl Rule {
             Rule::ImplicitNamespacePackage | Rule::InvalidModuleName => LintSource::Filesystem,
             Rule::IndentationWithInvalidMultiple
             | Rule::IndentationWithInvalidMultipleComment
+            | Rule::UnderIndentedHangingIndent
+            | Rule::MissingOrOutdentedIndentation
+            | Rule::ClosingBracketNotMatchingOpeningBracketIndentation
+            | Rule::ClosingBracketNotMatchingOpeningBracketVisualIndentation
+            | Rule::ContinuationLineIndentSameAsNextLogicalLine
+            | Rule::ContinuationLineOverIndentedForHangingIndent
+            | Rule::ContinuationLineOverIndentedForVisualIndent
+            | Rule::ContinuationLineUnderIndentedForVisualIndent
+            | Rule::VisuallyIndentedLineWithSameIndentAsNextLogicalLine
+            | Rule::ContinuationLineUnalignedForHangingIndent
+            | Rule::ClosingBracketMissingIndentation
             | Rule::MissingWhitespace
             | Rule::MissingWhitespaceAfterKeyword
             | Rule::MissingWhitespaceAroundArithmeticOperator

crates/ruff_linter/src/rules/pycodestyle/mod.rs

@@ -122,6 +122,31 @@ mod tests {
     #[test_case(Rule::TooFewSpacesBeforeInlineComment, Path::new("E26.py"))]
     #[test_case(Rule::UnexpectedIndentation, Path::new("E11.py"))]
     #[test_case(Rule::UnexpectedIndentationComment, Path::new("E11.py"))]
+    #[test_case(Rule::UnderIndentedHangingIndent, Path::new("E12.py"))]
+    #[test_case(Rule::MissingOrOutdentedIndentation, Path::new("E12.py"))]
+    #[test_case(
+        Rule::ClosingBracketNotMatchingOpeningBracketIndentation,
+        Path::new("E12.py")
+    )]
+    #[test_case(
+        Rule::ClosingBracketNotMatchingOpeningBracketVisualIndentation,
+        Path::new("E12.py")
+    )]
+    #[test_case(Rule::ContinuationLineIndentSameAsNextLogicalLine, Path::new("E12.py"))]
+    #[test_case(
+        Rule::ContinuationLineOverIndentedForHangingIndent,
+        Path::new("E12.py")
+    )]
+    #[test_case(Rule::ContinuationLineOverIndentedForVisualIndent, Path::new("E12.py"))]
+    #[test_case(
+        Rule::ContinuationLineUnderIndentedForVisualIndent,
+        Path::new("E12.py")
+    )]
+    #[test_case(
+        Rule::VisuallyIndentedLineWithSameIndentAsNextLogicalLine,
+        Path::new("E12.py")
+    )]
+    #[test_case(Rule::ContinuationLineUnalignedForHangingIndent, Path::new("E12.py"))]
     #[test_case(Rule::WhitespaceAfterOpenBracket, Path::new("E20.py"))]
     #[test_case(Rule::WhitespaceBeforeCloseBracket, Path::new("E20.py"))]
     #[test_case(Rule::WhitespaceBeforePunctuation, Path::new("E20.py"))]