Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ecosystem check when no changes detected #8520

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Conversation

T-256
Copy link
Contributor

@T-256 T-256 commented Nov 6, 2023

Summary

For example, #8512 doesn't need ecosystem check

Test Plan

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm okay, I'm not sure saving the 50s is critical but why not :) thanks!

@zanieb
Copy link
Member

zanieb commented Nov 6, 2023

@T-256 it doesn't show up until after its needs jobs complete.

All of these checks are expected to run when the workflow itself is modified.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@zanieb zanieb merged commit 7296452 into astral-sh:main Nov 6, 2023
17 checks passed
@zanieb zanieb added the internal An internal refactor or improvement label Nov 6, 2023
@T-256 T-256 deleted the patch-4 branch November 6, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants