[TRIO] Add TRIO115: TrioZeroSleepCall
#8486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdegraaf
commented
Nov 4, 2023
| } | ||
| } | ||
| Expr::Name(ast::ExprName { id, .. }) => { | ||
| let scope = checker.semantic().current_scope(); |
There was a problem hiding this comment.
I couldn't find a more compact way to do this yet. In case there is one somewhere in the repo already, happy to hear about it and refactor this.
qdegraaf
commented
Nov 4, 2023
| /// Checks for calls of `trio.sleep(0)` and suggests replacement with `trio.lowlevel.checkpoint()` | ||
| /// | ||
| /// ## Why is this bad? | ||
| /// Although equivalent to `trio.sleep(0)`, a call to `trio.lowlevel.checkpoint()` is more |
There was a problem hiding this comment.
Interpreted from upstream plugin, couldn't find additional info in docs or PRs on the reason. All input is welcome
|
charliermarsh
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
TRIO115from the flake8-trio plugin.Test Plan
Added a new fixture, based on the one from upstream plugin
Issue link
Relates to: #8451