Insert necessary blank line between class and leading comments #8224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given:
We need to insert an additional newline between
# comment
andclass A
. We were missing this handling for the case in which# comment
is a leading comment onclass A
, as opposed to a trailing comment of some preceding statement.In practice, I think this only applies to the specific case in which a class or function is the first statement in a module, and there's a single empty line between a leading comment and that class or function. If there are no empty lines, then the comment "sticks" to the definition; if there are two or more, then
leading_comments
will truncate appropriately. If the class or function is nested, then we only need one empty line anyway.Closes #8215.
Test Plan
No change in similarity.
Before:
After: