Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rule B005 docs #8028

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Update rule B005 docs #8028

merged 1 commit into from
Oct 17, 2023

Conversation

ahmedabdou14
Copy link
Contributor

@ahmedabdou14 ahmedabdou14 commented Oct 17, 2023 •
edited
Loading

Summary

Rule B005 of flake8-bugbear docs has a typo in one of the examples that leads to a confusion in the correctness of .strip() method

image

# Wrong output (used in docs) 
"text.txt".strip(".txt")  # "ex" 

# Correct output
"text.txt".strip(".txt")  # "e"

@ahmedabdou14 ahmedabdou14 mentioned this pull request Oct 17, 2023
Closed
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@ahmedabdou14 ahmedabdou14 changed the title Update strip_with_multi_characters.rs doc Update rule B005 docs Oct 17, 2023
@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Oct 17, 2023
@charliermarsh charliermarsh merged commit d85950c into astral-sh:main Oct 17, 2023
16 checks passed
@charliermarsh
Copy link
Member

Thank you!

@ahmedabdou14 ahmedabdou14 deleted the docs/fix_rule_b005_example branch October 17, 2023 22:39
@p-linnane p-linnane mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedabdou14 @charliermarsh