Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example of an unsafe fix #7924

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add an example of an unsafe fix #7924

merged 2 commits into from
Oct 11, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Oct 11, 2023 •
edited
Loading

Per review in #7901 adds an example of an unsafe fix.

@zanieb zanieb added the documentation Improvements or additions to documentation label Oct 11, 2023
@zanieb zanieb force-pushed the zanie/example-unsafe branch from 9465080 to ea17666 Compare October 11, 2023 20:54
charliermarsh
charliermarsh approved these changes Oct 11, 2023
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
@zanieb zanieb enabled auto-merge (squash) October 11, 2023 21:05
@zanieb zanieb merged commit b243840 into main Oct 11, 2023
15 checks passed
@zanieb zanieb deleted the zanie/example-unsafe branch October 11, 2023 21:14
@konstin
Copy link
Member

konstin commented Oct 12, 2023

That's a great example!

@p-linnane p-linnane mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanieb @konstin @charliermarsh