[docs] Default to following the system dark/light mode #7888
Conversation
|
That is a good idea, unfortunately it doesn't seem to work for me (firefox on ubuntu 22.04). Other tabs change theme, but the ruffs docs don't. I can see the "Linting the CPython codebase from scratch" figure switch themes though so i'm surprised the rest of the page doesn't. |
konstin
changed the title
|
It says the change is only in tag insiders-4.18.0, and the little heart says “sponsors only”.
I’m not sure how building ruff’s docs works. Does the presence of mkdocs.insiders.yml mean that the docs can be built with and without insiders “mode”? If that assumption is correct, my change should probably live in the mkdocs.insiders.yml instead. |
|
@konstin - Just confirming, are you building with insiders locally? |
|
Nope sorry i missed, i still have to check this with insiders (or someone else with access, i'm currently working on #7873 and would return to this PR later today) |
## Summary This fixes the theme toggle so it has the most useful setting on by default: following the system dark/light mode See https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/#automatic-light-dark-mode ## Test Plan It follows the official docs exactly. If the docs get published for each PR branch, we can also check there if it works as intended. --------- Co-authored-by: konstin <[email protected]>
Summary
This fixes the theme toggle so it has the most useful setting on by default: following the system dark/light mode
See https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/#automatic-light-dark-mode
Test Plan
It follows the official docs exactly. If the docs get published for each PR branch, we can also check there if it works as intended.