Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve trailing comments in C414 fixes #7775

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Preserve trailing comments in C414 fixes #7775

merged 1 commit into from
Oct 3, 2023

Conversation

charliermarsh
Copy link
Member

Closes #7772.

@charliermarsh charliermarsh added bug Something isn't working fixes Related to suggested fixes for violations labels Oct 3, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) October 3, 2023 04:26
@charliermarsh charliermarsh merged commit c040fac into main Oct 3, 2023
14 checks passed
@charliermarsh charliermarsh deleted the charlie/C414 branch October 3, 2023 04:36
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2023

CodSpeed Performance Report

Merging #7775 will degrade performances by 2.36%

Comparing charlie/C414 (c1a1f2e) with main (a6ebbf2)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/C414 Change
❌ linter/default-rules[pydantic/types.py] 38 ms 38.9 ms -2.36%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@p-linnane p-linnane mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C414 removes comment
1 participant
@charliermarsh