Prefer preserving WithItem
parentheses
#7694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a deviation to Black when formatting
WithItem
s.Black formats this as:
Notice that the two examples are identical except that the second example has parentheses around the with context expression.
Ruff formats both examples as if the context expression is not parenthesized:
This PR uses the
IfBreaks
layout that prefers parenthesizing the context manager when it is already parenthesized in source, aligning the behavior with black.Closes #7441
Test Plan
Added tests. I reviewed the changes and they now match black's formatting.
The similarity index remains unchanged.