Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move refurb/helpers utils to ruff_python_semantic for broader use #6990

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

qdegraaf
Copy link
Contributor

Summary

The utils added for refurb in its helpers.rs file could be useful for many other plugins. (Such as the PERF4XX codes, see e.g. #6132 ).

This PR moves them to ruff_python_semantic::analyzers::typing as suggested in #6132 (comment)

Test Plan

Confirmed refurb and all other tests still work

@qdegraaf qdegraaf mentioned this pull request Aug 29, 2023
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh merged commit f3aaf84 into astral-sh:main Aug 29, 2023
@qdegraaf qdegraaf deleted the ref/moverefurbutils branch August 29, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants