Format bytes string #6166
Merged
Format bytes string #6166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Check ResultsBenchmarkLinuxWindows |
72 tasks
MichaReiser
approved these changes
Jul 31, 2023
| @@ -51,16 +51,13 @@ impl FormatNodeRule<ExprConstant> for FormatExprConstant { | |||
| Constant::Int(_) => FormatInt::new(item).fmt(f), | |||
| Constant::Float(_) => FormatFloat::new(item).fmt(f), | |||
| Constant::Complex { .. } => FormatComplex::new(item).fmt(f), | |||
| Constant::Str(_) => { | |||
| Constant::Str(_) | Constant::Bytes(_) => { | |||
| let string_layout = match self.layout { | |||
| ExprConstantLayout::Default => StringLayout::Default, | |||
| ExprConstantLayout::String(layout) => layout, | |||
| }; | |||
| FormatString::new(item).with_layout(string_layout).fmt(f) | |||
There was a problem hiding this comment.
@konstin I'm a bit surprised that black also normalizes byte strings because I assumed we would need to treat them as opaque bytes. Are you aware of any normalization that isn't safe for byte strings?
There was a problem hiding this comment.
as far as i know and reading https://docs.python.org/3/library/stdtypes.html#bytes, byte strings are pretty much like normal strings except that they are limited to ascii input, allow arbitrary bytes and \x behaves differently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Format bytes string
Closes #6064
Test Plan
Added a fixture based on string's one