Fix formatting lambda with empty arguments #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Fix implemented in astral-sh/RustPython-Parser#35: Previously, empty lambda arguments (e.g. `lambda: 1`) would get the range of the entire expression, which leads to incorrect comment placement. Now empty lambda arguments get an empty range between the `lambda` and the `:` tokens. **Test Plan** Added a regression test. 149 instances of unstable formatting remaining. ``` $ cargo run --bin ruff_dev --release -- format-dev --stability-check --error-file formatter-ecosystem-errors.txt --multi-project target/checkouts > formatter-ecosystem-progress.txt $ rg "Unstable formatting" target/formatter-ecosystem-errors.txt | wc -l 149 ```
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
konstin
force-pushed
the
lambda_ranges_and_formatting_bugs
branch
from
721efed to
62deacb
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
konstin
force-pushed
the
lambda_ranges_and_formatting_bugs
branch
from
1dd8126 to
62deacb
Compare
MichaReiser
approved these changes
Jul 21, 2023
197 was the last measurement before, but i haven't keeping track of which are mine and which are unrelated from main |
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Fix implemented in astral-sh/RustPython-Parser#35: Previously, empty lambda arguments (e.g.
lambda: 1) would get the range of the entire expression, which leads to incorrect comment placement. Now empty lambda arguments get an empty range between thelambdaand the:tokens.Test Plan Added a regression test.
149 instances of unstable formatting remaining.