Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom error type for symbol-import results #4688

Merged
merged 2 commits into from
May 30, 2023

Conversation

charliermarsh
Copy link
Member

Summary

Follow-up to a previous PR -- see #4649 (comment) for context.

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.02     18.7±0.41ms     2.2 MB/sec    1.00     18.3±0.44ms     2.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.5±0.10ms     3.7 MB/sec    1.00      4.4±0.13ms     3.8 MB/sec
linter/all-rules/numpy/globals.py          1.02   564.5±18.26µs     5.2 MB/sec    1.00   551.1±18.92µs     5.4 MB/sec
linter/all-rules/pydantic/types.py         1.03      7.8±0.15ms     3.3 MB/sec    1.00      7.6±0.19ms     3.4 MB/sec
linter/default-rules/large/dataset.py      1.00      8.9±0.17ms     4.6 MB/sec    1.01      9.0±0.45ms     4.5 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02  1957.3±36.62µs     8.5 MB/sec    1.00  1913.8±58.28µs     8.7 MB/sec
linter/default-rules/numpy/globals.py      1.07   242.8±17.15µs    12.2 MB/sec    1.00   226.5±10.09µs    13.0 MB/sec
linter/default-rules/pydantic/types.py     1.03      4.1±0.27ms     6.2 MB/sec    1.00      4.0±0.11ms     6.4 MB/sec
parser/large/dataset.py                    1.00      6.8±0.14ms     6.0 MB/sec    1.00      6.8±0.21ms     6.0 MB/sec
parser/numpy/ctypeslib.py                  1.00  1382.7±34.40µs    12.0 MB/sec    1.02  1410.2±103.73µs    11.8 MB/sec
parser/numpy/globals.py                    1.02    135.9±4.54µs    21.7 MB/sec    1.00    133.9±8.35µs    22.0 MB/sec
parser/pydantic/types.py                   1.00      3.1±0.07ms     8.3 MB/sec    1.00      3.1±0.23ms     8.3 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.04     18.7±0.48ms     2.2 MB/sec    1.00     18.0±0.40ms     2.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.6±0.13ms     3.7 MB/sec    1.00      4.5±0.21ms     3.7 MB/sec
linter/all-rules/numpy/globals.py          1.00   538.5±30.70µs     5.5 MB/sec    1.01   541.2±29.11µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.02      7.8±0.20ms     3.3 MB/sec    1.00      7.7±0.23ms     3.3 MB/sec
linter/default-rules/large/dataset.py      1.04      9.3±0.19ms     4.4 MB/sec    1.00      9.0±0.33ms     4.5 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.04  1957.1±54.97µs     8.5 MB/sec    1.00  1886.1±100.84µs     8.8 MB/sec
linter/default-rules/numpy/globals.py      1.05   220.9±12.47µs    13.4 MB/sec    1.00    211.4±7.40µs    14.0 MB/sec
linter/default-rules/pydantic/types.py     1.05      4.1±0.08ms     6.2 MB/sec    1.00      3.9±0.11ms     6.5 MB/sec
parser/large/dataset.py                    1.00      6.6±0.14ms     6.2 MB/sec    1.00      6.6±0.12ms     6.1 MB/sec
parser/numpy/ctypeslib.py                  1.00  1252.0±29.47µs    13.3 MB/sec    1.00  1255.2±25.69µs    13.3 MB/sec
parser/numpy/globals.py                    1.00    129.0±6.80µs    22.9 MB/sec    1.00    128.4±4.52µs    23.0 MB/sec
parser/pydantic/types.py                   1.01      2.9±0.10ms     8.9 MB/sec    1.00      2.8±0.07ms     9.0 MB/sec

@charliermarsh charliermarsh merged commit 0854543 into main May 30, 2023
@charliermarsh charliermarsh deleted the charlie/error-type branch May 30, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants