Fix B023 shadowed variables in nested functions

[MichaReiser]

Fixes #4090

The issue was that we didn't return early for FunctionDefs and Lambda expressions and, therefore, visited the body twice. This becomes a problem if there are nested functions because we then no-longer exclude the outer function's argument names from the suspicious variables.

This should also be good for performance because we no longer visit the body of every function twice (O(l^2) where l is the nesting level)

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Fix B023 shadowed variables in nested functions #4111 👈

This comment was auto-generated by Graphite.

[MichaReiser]

This is the real fix. We don't want to walk the function node again because that results in visiting the argument initializers (and a lot of unnecessary visiting)

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     15.3±0.05ms     2.7 MB/sec    1.00     15.4±0.07ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.9±0.00ms     4.3 MB/sec    1.00      3.9±0.00ms     4.3 MB/sec
linter/all-rules/numpy/globals.py          1.00    424.7±1.59µs     6.9 MB/sec    1.00    425.6±2.04µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.5±0.02ms     3.9 MB/sec    1.01      6.6±0.02ms     3.9 MB/sec
linter/default-rules/large/dataset.py      1.00      8.0±0.01ms     5.1 MB/sec    1.01      8.1±0.02ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1763.4±2.99µs     9.4 MB/sec    1.00   1767.9±4.27µs     9.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    182.7±0.29µs    16.1 MB/sec    1.02    185.7±1.14µs    15.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.01ms     7.0 MB/sec    1.02      3.7±0.01ms     6.9 MB/sec
parser/large/dataset.py                    1.02      6.4±0.00ms     6.3 MB/sec    1.00      6.3±0.00ms     6.4 MB/sec
parser/numpy/ctypeslib.py                  1.00   1259.0±2.33µs    13.2 MB/sec    1.00   1258.6±1.59µs    13.2 MB/sec
parser/numpy/globals.py                    1.00    124.9±1.09µs    23.6 MB/sec    1.01    126.6±0.51µs    23.3 MB/sec
parser/pydantic/types.py                   1.00      2.7±0.00ms     9.3 MB/sec    1.00      2.7±0.00ms     9.3 MB/sec

Windows

group                                      main                                    pr
-----                                      ----                                    --
linter/all-rules/large/dataset.py          1.01     22.0±0.56ms  1896.6 KB/sec     1.00     21.7±0.67ms  1919.2 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      5.6±0.18ms     3.0 MB/sec     1.00      5.6±0.17ms     3.0 MB/sec
linter/all-rules/numpy/globals.py          1.00   678.4±23.49µs     4.3 MB/sec     1.00   680.1±34.65µs     4.3 MB/sec
linter/all-rules/pydantic/types.py         1.00      9.3±0.40ms     2.7 MB/sec     1.01      9.3±0.54ms     2.7 MB/sec
linter/default-rules/large/dataset.py      1.04     11.3±0.57ms     3.6 MB/sec     1.00     10.9±0.28ms     3.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.4±0.10ms     6.9 MB/sec     1.01      2.4±0.14ms     6.8 MB/sec
linter/default-rules/numpy/globals.py      1.00   294.0±19.95µs    10.0 MB/sec     1.00   292.7±18.53µs    10.1 MB/sec
linter/default-rules/pydantic/types.py     1.02      5.2±0.29ms     4.9 MB/sec     1.00      5.1±0.28ms     5.0 MB/sec
parser/large/dataset.py                    1.01      8.9±0.20ms     4.6 MB/sec     1.00      8.8±0.25ms     4.6 MB/sec
parser/numpy/ctypeslib.py                  1.03  1744.6±174.00µs     9.5 MB/sec    1.00  1687.4±52.22µs     9.9 MB/sec
parser/numpy/globals.py                    1.00   179.2±14.87µs    16.5 MB/sec     1.00    178.7±7.16µs    16.5 MB/sec
parser/pydantic/types.py                   1.00      3.8±0.16ms     6.6 MB/sec     1.01      3.9±0.52ms     6.6 MB/sec