Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement flake8-i18n (#3741)" #3765

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Revert "Implement flake8-i18n (#3741)" #3765

merged 1 commit into from
Mar 27, 2023

Conversation

charliermarsh
Copy link
Member

Reverting #3741 while we figure out licensing questions.

@charliermarsh charliermarsh enabled auto-merge (squash) March 27, 2023 21:01
@charliermarsh charliermarsh merged commit c3917ea into main Mar 27, 2023
@charliermarsh charliermarsh deleted the charlie/revert branch March 27, 2023 21:14
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+0, -1, 0 error(s))

zulip (+0, -1)

- corporate/lib/stripe.py:1010:17: INT001 f-string is resolved before function call; consider `_("string %s") % arg`

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     18.7±0.69ms     2.2 MB/sec    1.02     19.1±0.56ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.8±0.25ms     3.5 MB/sec    1.01      4.8±0.18ms     3.4 MB/sec
linter/all-rules/numpy/globals.py          1.04   671.2±40.12µs     4.4 MB/sec    1.00   644.8±34.44µs     4.6 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.1±0.26ms     3.2 MB/sec    1.05      8.4±0.36ms     3.0 MB/sec
linter/default-rules/large/dataset.py      1.00     10.0±0.35ms     4.1 MB/sec    1.02     10.1±0.61ms     4.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.2±0.09ms     7.7 MB/sec    1.01      2.2±0.10ms     7.6 MB/sec
linter/default-rules/numpy/globals.py      1.01   264.3±13.07µs    11.2 MB/sec    1.00   261.3±13.04µs    11.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.6±0.18ms     5.6 MB/sec    1.02      4.7±0.35ms     5.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     18.9±0.64ms     2.1 MB/sec    1.01     19.1±0.47ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.0±0.15ms     3.3 MB/sec    1.01      5.1±0.21ms     3.3 MB/sec
linter/all-rules/numpy/globals.py          1.01   662.8±36.64µs     4.5 MB/sec    1.00   656.0±25.93µs     4.5 MB/sec
linter/all-rules/pydantic/types.py         1.01      8.4±0.24ms     3.0 MB/sec    1.00      8.3±0.30ms     3.1 MB/sec
linter/default-rules/large/dataset.py      1.00     10.1±0.50ms     4.0 MB/sec    1.02     10.3±0.55ms     4.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.3±0.09ms     7.4 MB/sec    1.01      2.3±0.11ms     7.3 MB/sec
linter/default-rules/numpy/globals.py      1.00   258.9±12.14µs    11.4 MB/sec    1.03   266.1±15.77µs    11.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.8±0.29ms     5.3 MB/sec    1.00      4.8±0.17ms     5.3 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant