Replace logical_lines feature with debug_assertions
#3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/debug-flag
branch
from
5426db3 to
9f51896
Compare
MichaReiser
approved these changes
Mar 21, 2023
| @@ -23,7 +23,7 @@ macro_rules! check { | |||
| #[wasm_bindgen_test] | |||
| fn empty_config() { | |||
| check!( | |||
| "if (1, 2):\n pass", | |||
There was a problem hiding this comment.
Are the changes in this file intentional?
There was a problem hiding this comment.
Yeah, because these rules are now enabled in debug here (whereas before, I don't think we were running with --all-features). So without these changes, we get additional pycodestyle errors.
MichaReiser
changed the title
logical_lines flag with debug_assertionslogical_lines feature with debug_assertions
charliermarsh
force-pushed
the
charlie/debug-flag
branch
from
9f51896 to
18d50e0
Compare
JonathanPlasse
added a commit
to JonathanPlasse/ruff
that referenced
this pull request
Mar 24, 2023
…al-sh#3648)" This reverts commit 27903cd.
charliermarsh
pushed a commit
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #3557 (comment).