feat(B029): Add B029 from flake8-bugbear #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| x = 1 | ||
| except(): | ||
| print("error") |
There was a problem hiding this comment.
Can we replace this with the version from flake8-bugbear itself?
"""
Should emit:
B029 - on lines 8 and 13
"""
try:
pass
except ():
pass
try:
pass
except () as e:
passThere was a problem hiding this comment.
@charliermarsh sure!
|
Looking good! |
| column: 18 | ||
| fix: ~ | ||
| parent: ~ | ||
|
|
There was a problem hiding this comment.
Do you have insta installed? (cargo install cargo-insta) You should be able to run cargo test --lib, then cargo insta review to review and check in the generated snapshot.
There was a problem hiding this comment.
@charliermarsh yeah it's weird I did run cargo test --all and cargo insta review but the file was not updated 🤔
There was a problem hiding this comment.
(result from running test --all and cargo insta review
There was a problem hiding this comment.
Oh, you need to add the test to crates/ruff/src/rules/flake8_bugbear/mod.rs (hopefully the pattern is clear once you open up that file).
There was a problem hiding this comment.
@charliermarsh nvm 🤦 I accidentally deleted it upon resolving the merge conflict here 
will restore it asap
There was a problem hiding this comment.
Happens to the best of us :D
|
Thanks! |
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Feb 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.249` -> `^0.0.251` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.251`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.251) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.250...v0.0.251) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Bug Fixes - Create bindings for `MatchAs` patterns by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3098](https://togithub.com/charliermarsh/ruff/pull/3098) - Avoid prefer-list-builtin for lambdas with `*args` or `**kwargs` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3102](https://togithub.com/charliermarsh/ruff/pull/3102) **Full Changelog**: astral-sh/ruff@v0.0.250...v0.0.251 ### [`v0.0.250`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.250) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.249...v0.0.250) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed **Ruff now supports all Python 3.10 and 3.11 language features**, including: - Structural Pattern Patching (`match` statements) ([PEP 634](https://peps.python.org/pep-0634/#class-patterns)) - Exception Groups (`except*` statements) ([PEP 654](https://peps.python.org/pep-0654/)) ##### Rules - \[`flake8-bugbear`] Add B029 (`except-with-empty-tuple`) from flake8-bugbear by [@​carlosmiei](https://togithub.com/carlosmiei) in [https://github.com/charliermarsh/ruff/pull/3068](https://togithub.com/charliermarsh/ruff/pull/3068) - \[`flake8-bugbear`] Add B032 (`unintentional-type-annotation`) from flake8\_bugbear by [@​carlosmiei](https://togithub.com/carlosmiei) in [https://github.com/charliermarsh/ruff/pull/3085](https://togithub.com/charliermarsh/ruff/pull/3085) - \[`tryceratops`]: Add TRY401 (`verbose-log-messages`) by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/3036](https://togithub.com/charliermarsh/ruff/pull/3036) - \[`flake8-simplify`]: Add SIM116 (`manual-dict-lookup`) by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/2767](https://togithub.com/charliermarsh/ruff/pull/2767) ##### Features - Add support for TryStar by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3089](https://togithub.com/charliermarsh/ruff/pull/3089) - Add support for structural pattern matching by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3047](https://togithub.com/charliermarsh/ruff/pull/3047) ##### Bug Fixes - \[`flake8-pytest`] Use LibCST to fix chained assertions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3087](https://togithub.com/charliermarsh/ruff/pull/3087) - \[`flake8-boolean-trap`] Avoid boolean-trap rules for positional-only builtin calls by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3075](https://togithub.com/charliermarsh/ruff/pull/3075) - \[`flake8-boolean-trap`] Ignore setters in flake8-boolean-trap by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3092](https://togithub.com/charliermarsh/ruff/pull/3092) - \[`flake8-return`] Omit `while-True` loops from implicit return enforcement by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3076](https://togithub.com/charliermarsh/ruff/pull/3076) #### New Contributors - [@​carlosmiei](https://togithub.com/carlosmiei) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3068](https://togithub.com/charliermarsh/ruff/pull/3068) **Full Changelog**: astral-sh/ruff@v0.0.249...v0.0.250 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=--> Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in allenporter/flux-local
Mar 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.247` -> `==0.0.253` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.253`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.253) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.252...v0.0.253) <!-- Release notes generated using configuration in .github/release.yml at 386ca7c9a1bb7ebeb1457b605695c6a09e67092b --> #### What's Changed ##### Rules - \[`pyupgrade`] Avoid rewriting any PEP 604 runtime annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3217](https://togithub.com/charliermarsh/ruff/pull/3217) - \[`pycodestyle`] Missing whitespace after keyword by [@​carlosmiei](https://togithub.com/carlosmiei) in [https://github.com/charliermarsh/ruff/pull/3225](https://togithub.com/charliermarsh/ruff/pull/3225) - \[`pycodestyle`] trailing-whitespace, blank-line-contains-whitespace (W291, W293) by [@​mknaw](https://togithub.com/mknaw) in [https://github.com/charliermarsh/ruff/pull/3122](https://togithub.com/charliermarsh/ruff/pull/3122) - \[`flake8-pyi`]: PYI009, PYI010, PYI021 by [@​sbdchd](https://togithub.com/sbdchd) in [https://github.com/charliermarsh/ruff/pull/3230](https://togithub.com/charliermarsh/ruff/pull/3230) - \[`flake8-pyi`]: PYI011, PYI014 by [@​sbdchd](https://togithub.com/sbdchd) in [https://github.com/charliermarsh/ruff/pull/3238](https://togithub.com/charliermarsh/ruff/pull/3238) - \[`flake8-django`] DJ003, DJ006, DJ007 by [@​lkh42t](https://togithub.com/lkh42t) in [https://github.com/charliermarsh/ruff/pull/3236](https://togithub.com/charliermarsh/ruff/pull/3236) - \[`pylint`] Implement pylint's `else-if-used` rule (`PLR5501`) by [@​chanman3388](https://togithub.com/chanman3388) in [https://github.com/charliermarsh/ruff/pull/3231](https://togithub.com/charliermarsh/ruff/pull/3231) - \[`pylint`] W0603: global-statement by [@​igozali](https://togithub.com/igozali) in [https://github.com/charliermarsh/ruff/pull/3227](https://togithub.com/charliermarsh/ruff/pull/3227) - \[`flake8-pie`] Unnecessary list comprehension, with autofix (PIE802) by [@​matthewlloyd](https://togithub.com/matthewlloyd) in [https://github.com/charliermarsh/ruff/pull/3149](https://togithub.com/charliermarsh/ruff/pull/3149) ##### Settings - Allow ruff.toml file to be dot-prefixed (as .ruff.toml) by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3221](https://togithub.com/charliermarsh/ruff/pull/3221) - \[`pydocstyle`]: Implement `ignore-decorators` by [@​edgarrmondragon](https://togithub.com/edgarrmondragon) in [https://github.com/charliermarsh/ruff/pull/3229](https://togithub.com/charliermarsh/ruff/pull/3229) ##### Bug Fixes - Avoid suggesting 'is' for constant literals by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3146](https://togithub.com/charliermarsh/ruff/pull/3146) - Omit non-.py\[i] files from module naming rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3153](https://togithub.com/charliermarsh/ruff/pull/3153) - Bind star patterns in match statements by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3169](https://togithub.com/charliermarsh/ruff/pull/3169) - Update RustPython to support \*tuple annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3178](https://togithub.com/charliermarsh/ruff/pull/3178) - Use `writeln` with --show-settings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3180](https://togithub.com/charliermarsh/ruff/pull/3180) - Avoid boolean-trap rules for ConfigParser get() methods by [@​monosans](https://togithub.com/monosans) in [https://github.com/charliermarsh/ruff/pull/3209](https://togithub.com/charliermarsh/ruff/pull/3209) - Avoid flagging logging-too-few-args with no arguments by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3220](https://togithub.com/charliermarsh/ruff/pull/3220) - Expand the range of the COM812 autofix to include the preceding token by [@​matthewlloyd](https://togithub.com/matthewlloyd) in [https://github.com/charliermarsh/ruff/pull/3241](https://togithub.com/charliermarsh/ruff/pull/3241) - Avoid flagging Pylint logging rules with starred arguments by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3244](https://togithub.com/charliermarsh/ruff/pull/3244) - Avoid flagging unfixable `TypedDict` and `NamedTuple` definitions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3148](https://togithub.com/charliermarsh/ruff/pull/3148) - Fix ExceptionGroup F821 false positive by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/3167](https://togithub.com/charliermarsh/ruff/pull/3167) - Avoid autofixing some PT violations when comments are present by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3198](https://togithub.com/charliermarsh/ruff/pull/3198) - Exclude globsets for --show-settings by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3201](https://togithub.com/charliermarsh/ruff/pull/3201) - \[`flake8-tidy-imports`] fix autofix for relative imports by [@​sciyoshi](https://togithub.com/sciyoshi) in [https://github.com/charliermarsh/ruff/pull/3197](https://togithub.com/charliermarsh/ruff/pull/3197) - Fix Markdown errors in docs by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/3187](https://togithub.com/charliermarsh/ruff/pull/3187) - Normalize treatment of aliased and unaliased imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3216](https://togithub.com/charliermarsh/ruff/pull/3216) - Avoid EXE001 and EXE002 errors from stdin input by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3218](https://togithub.com/charliermarsh/ruff/pull/3218) - \[bandit]: Do not treat "passed" as "password" for `S105`/`S106`/`S107` by [@​edgarrmondragon](https://togithub.com/edgarrmondragon) in [https://github.com/charliermarsh/ruff/pull/3222](https://togithub.com/charliermarsh/ruff/pull/3222) #### New Contributors - [@​mknaw](https://togithub.com/mknaw) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3122](https://togithub.com/charliermarsh/ruff/pull/3122) - [@​monosans](https://togithub.com/monosans) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3209](https://togithub.com/charliermarsh/ruff/pull/3209) - [@​lkh42t](https://togithub.com/lkh42t) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3236](https://togithub.com/charliermarsh/ruff/pull/3236) - [@​igozali](https://togithub.com/igozali) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3227](https://togithub.com/charliermarsh/ruff/pull/3227) **Full Changelog**: astral-sh/ruff@v0.0.252...v0.0.253 ### [`v0.0.252`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.252) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.251...v0.0.252) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`pylint`] `redefined-loop-name` (`W2901`) by [@​matthewlloyd](https://togithub.com/matthewlloyd) in [https://github.com/charliermarsh/ruff/pull/3022](https://togithub.com/charliermarsh/ruff/pull/3022) - \[`pylint`] ` logging-too-many-args ` (`E1205`) by [@​md384](https://togithub.com/md384) in [https://github.com/charliermarsh/ruff/pull/3084](https://togithub.com/charliermarsh/ruff/pull/3084) - \[`pylint`] ` logging-too-few-args ` (`E1206`) by [@​md384](https://togithub.com/md384) in [https://github.com/charliermarsh/ruff/pull/3084](https://togithub.com/charliermarsh/ruff/pull/3084) ##### Bug Fixes - Include file permissions in cache key by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3104](https://togithub.com/charliermarsh/ruff/pull/3104) - Skip EXE001 and EXE002 rules on Windows by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3111](https://togithub.com/charliermarsh/ruff/pull/3111) - Mark `typing.assert_never` as no return by [@​bluetech](https://togithub.com/bluetech) in [https://github.com/charliermarsh/ruff/pull/3121](https://togithub.com/charliermarsh/ruff/pull/3121) - Use file-specific quote for C408 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3128](https://togithub.com/charliermarsh/ruff/pull/3128) - Avoid match statement misidentification in token rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3129](https://togithub.com/charliermarsh/ruff/pull/3129) - Upgrade RustPython to handle trailing commas in map patterns by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3130](https://togithub.com/charliermarsh/ruff/pull/3130) - Avoid useless-else-on-loop for break within match by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3136](https://togithub.com/charliermarsh/ruff/pull/3136) - Fix isort `no-lines-before` preceded by an empty section by [@​bluetech](https://togithub.com/bluetech) in [https://github.com/charliermarsh/ruff/pull/3139](https://togithub.com/charliermarsh/ruff/pull/3139) - Support shell expansion for --config argument by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3107](https://togithub.com/charliermarsh/ruff/pull/3107) - Fix =/== error in `ManualDictLookup` by [@​Rupt](https://togithub.com/Rupt) in [https://github.com/charliermarsh/ruff/pull/3117](https://togithub.com/charliermarsh/ruff/pull/3117) - Include match in nested block check by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3137](https://togithub.com/charliermarsh/ruff/pull/3137) - Upgrade RustPython to match new flattened exports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3141](https://togithub.com/charliermarsh/ruff/pull/3141) #### New Contributors - [@​md384](https://togithub.com/md384) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3084](https://togithub.com/charliermarsh/ruff/pull/3084) - [@​Rupt](https://togithub.com/Rupt) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3117](https://togithub.com/charliermarsh/ruff/pull/3117) - [@​marijncv](https://togithub.com/marijncv) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3133](https://togithub.com/charliermarsh/ruff/pull/3133) **Full Changelog**: astral-sh/ruff@v0.0.251...v0.0.252 ### [`v0.0.251`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.251) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.250...v0.0.251) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Bug Fixes - Create bindings for `MatchAs` patterns by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3098](https://togithub.com/charliermarsh/ruff/pull/3098) - Avoid prefer-list-builtin for lambdas with `*args` or `**kwargs` by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3102](https://togithub.com/charliermarsh/ruff/pull/3102) **Full Changelog**: astral-sh/ruff@v0.0.250...v0.0.251 ### [`v0.0.250`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.250) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.249...v0.0.250) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed **Ruff now supports all Python 3.10 and 3.11 language features**, including: - Structural Pattern Patching (`match` statements) ([PEP 634](https://peps.python.org/pep-0634/#class-patterns)) - Exception Groups (`except*` statements) ([PEP 654](https://peps.python.org/pep-0654/)) ##### Rules - \[`flake8-bugbear`] Add B029 (`except-with-empty-tuple`) from flake8-bugbear by [@​carlosmiei](https://togithub.com/carlosmiei) in [https://github.com/charliermarsh/ruff/pull/3068](https://togithub.com/charliermarsh/ruff/pull/3068) - \[`flake8-bugbear`] Add B032 (`unintentional-type-annotation`) from flake8\_bugbear by [@​carlosmiei](https://togithub.com/carlosmiei) in [https://github.com/charliermarsh/ruff/pull/3085](https://togithub.com/charliermarsh/ruff/pull/3085) - \[`tryceratops`]: Add TRY401 (`verbose-log-messages`) by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/3036](https://togithub.com/charliermarsh/ruff/pull/3036) - \[`flake8-simplify`]: Add SIM116 (`manual-dict-lookup`) by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/2767](https://togithub.com/charliermarsh/ruff/pull/2767) ##### Features - Add support for TryStar by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3089](https://togithub.com/charliermarsh/ruff/pull/3089) - Add support for structural pattern matching by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3047](https://togithub.com/charliermarsh/ruff/pull/3047) ##### Bug Fixes - \[`flake8-pytest`] Use LibCST to fix chained assertions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3087](https://togithub.com/charliermarsh/ruff/pull/3087) - \[`flake8-boolean-trap`] Avoid boolean-trap rules for positional-only builtin calls by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3075](https://togithub.com/charliermarsh/ruff/pull/3075) - \[`flake8-boolean-trap`] Ignore setters in flake8-boolean-trap by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3092](https://togithub.com/charliermarsh/ruff/pull/3092) - \[`flake8-return`] Omit `while-True` loops from implicit return enforcement by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3076](https://togithub.com/charliermarsh/ruff/pull/3076) #### New Contributors - [@​carlosmiei](https://togithub.com/carlosmiei) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3068](https://togithub.com/charliermarsh/ruff/pull/3068) **Full Changelog**: astral-sh/ruff@v0.0.249...v0.0.250 ### [`v0.0.249`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.249) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.248...v0.0.249) <!-- Release notes generated using configuration in .github/release.yml at 4cfa350112a82fb631909fc555588f3da8ba5750 --> #### What's Changed ##### Bug Fixes - Relax constraints on pep8-naming module validation by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3043](https://togithub.com/charliermarsh/ruff/pull/3043) - Do not autofix `E731` in class bodies by [@​JoshKarpel](https://togithub.com/JoshKarpel) in [https://github.com/charliermarsh/ruff/pull/3050](https://togithub.com/charliermarsh/ruff/pull/3050) - Avoid assert() to assert statement conversion in expressions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3062](https://togithub.com/charliermarsh/ruff/pull/3062) #### New Contributors - [@​matthewlloyd](https://togithub.com/matthewlloyd) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3048](https://togithub.com/charliermarsh/ruff/pull/3048) - [@​JoshKarpel](https://togithub.com/JoshKarpel) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3050](https://togithub.com/charliermarsh/ruff/pull/3050) **Full Changelog**: astral-sh/ruff@v0.0.248...v0.0.249 ### [`v0.0.248`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.248) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.247...v0.0.248) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`numpy`] numpy-legacy-random by [@​sbrugman](https://togithub.com/sbrugman) in [https://github.com/charliermarsh/ruff/pull/2960](https://togithub.com/charliermarsh/ruff/pull/2960) - \[`pycodestyle`] autofix useless semicolons by [@​sbrugman](https://togithub.com/sbrugman) in [https://github.com/charliermarsh/ruff/pull/3001](https://togithub.com/charliermarsh/ruff/pull/3001) - \[`pep8-naming`] Implement `flake8-module-naming` by [@​sbrugman](https://togithub.com/sbrugman) in [https://github.com/charliermarsh/ruff/pull/2855](https://togithub.com/charliermarsh/ruff/pull/2855) - \[`flake8-self`] Ignore namedtuple methods in flake8-self by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2998](https://togithub.com/charliermarsh/ruff/pull/2998) - \[`flake8-simplify`] Merge convert-loop-to-any & convert-loop-to-all to reimplemented-builtin by [@​not-my-profile](https://togithub.com/not-my-profile) in [https://github.com/charliermarsh/ruff/pull/2903](https://togithub.com/charliermarsh/ruff/pull/2903) - \[`ruff`] Add support for `ensure_future` for RUF006 by [@​Lunarmagpie](https://togithub.com/Lunarmagpie) in [https://github.com/charliermarsh/ruff/pull/2943](https://togithub.com/charliermarsh/ruff/pull/2943) - \[`pylint`] error when `__init__` returns a value by [@​r3m0t](https://togithub.com/r3m0t) in [https://github.com/charliermarsh/ruff/pull/3007](https://togithub.com/charliermarsh/ruff/pull/3007) - \[`flake8-pytest-style`] autofix for composite-assertion (PT018) by [@​sbrugman](https://togithub.com/sbrugman) in [https://github.com/charliermarsh/ruff/pull/2732](https://togithub.com/charliermarsh/ruff/pull/2732) - \[`flake8-tidy-imports`] extend autofix of relative imports by [@​sbrugman](https://togithub.com/sbrugman) in [https://github.com/charliermarsh/ruff/pull/2990](https://togithub.com/charliermarsh/ruff/pull/2990) ##### Settings - Add support for file-scoped `noqa` directives by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2978](https://togithub.com/charliermarsh/ruff/pull/2978) - Add configuration option for C408 to allow dict calls with keyword arguments. by [@​manueljacob](https://togithub.com/manueljacob) in [https://github.com/charliermarsh/ruff/pull/2977](https://togithub.com/charliermarsh/ruff/pull/2977) - feat(isort): Implement isort.force_to_top by [@​spaceone](https://togithub.com/spaceone) in [https://github.com/charliermarsh/ruff/pull/2877](https://togithub.com/charliermarsh/ruff/pull/2877) ##### Bug Fixes - Fix add-required-import with multi-line offsets by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2946](https://togithub.com/charliermarsh/ruff/pull/2946) - Support positional messages in assertion rewrites by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3002](https://togithub.com/charliermarsh/ruff/pull/3002) - Avoid false-positives for break in with by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/3032](https://togithub.com/charliermarsh/ruff/pull/3032) - Avoid trying to fix implicit returns with control flow by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2962](https://togithub.com/charliermarsh/ruff/pull/2962) - Handle non-from **future** imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2974](https://togithub.com/charliermarsh/ruff/pull/2974) - Enforce D403 on methods by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2992](https://togithub.com/charliermarsh/ruff/pull/2992) - Avoid zero-indexed column for IOError by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2995](https://togithub.com/charliermarsh/ruff/pull/2995) - Fix for F541 unescape f-string by [@​sbrugman](https://togithub.com/sbrugman) in [https://github.com/charliermarsh/ruff/pull/2971](https://togithub.com/charliermarsh/ruff/pull/2971) - Avoid raising `B027` violations in `.pyi` files by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [https://github.com/charliermarsh/ruff/pull/3016](https://togithub.com/charliermarsh/ruff/pull/3016) #### New Contributors - [@​Lunarmagpie](https://togithub.com/Lunarmagpie) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2943](https://togithub.com/charliermarsh/ruff/pull/2943) - [@​manueljacob](https://togithub.com/manueljacob) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2966](https://togithub.com/charliermarsh/ruff/pull/2966) - [@​mwtoews](https://togithub.com/mwtoews) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2973](https://togithub.com/charliermarsh/ruff/pull/2973) - [@​ortem](https://togithub.com/ortem) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2976](https://togithub.com/charliermarsh/ruff/pull/2976) - [@​thatlittleboy](https://togithub.com/thatlittleboy) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3027](https://togithub.com/charliermarsh/ruff/pull/3027) - [@​r3m0t](https://togithub.com/r3m0t) made their first contribution in [https://github.com/charliermarsh/ruff/pull/3007](https://togithub.com/charliermarsh/ruff/pull/3007) **Full Changelog**: astral-sh/ruff@v0.0.247...v0.0.248 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM0LjE1My4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added B029 from flake8-bugbear
I think I followed all the required steps, but let me know if I missed something