Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate attribute-like macros in define_rule_mapping #2583

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Propagate attribute-like macros in define_rule_mapping #2583

merged 1 commit into from
Feb 5, 2023

Conversation

charliermarsh
Copy link
Member

This enables us to feature-flag rules, like:

ruff_macros::define_rule_mapping!(
    #[cfg(feature = "logical_lines")]
    E111 => rules::pycodestyle::rules::IndentationWithInvalidMultiple,
    ...
)

charliermarsh
charliermarsh commented Feb 5, 2023
View reviewed changes
ruff_macros/src/rule_code_prefix.rs
}
all_codes.insert(code_str);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, all_codes is unused.

@charliermarsh charliermarsh merged commit 452b5a4 into main Feb 5, 2023
@charliermarsh charliermarsh deleted the charlie/cfg branch February 5, 2023 17:26
@not-my-profile not-my-profile mentioned this pull request Feb 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliermarsh