flake8_simplify : SIM210, SIM211, SIM212 #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
simplify2
branch
from
32432c6 to
dbf4a9a
Compare
|
Great work, thank you! |
|
We've almost implemented the entire plugin :) |
|
Note that we just changed the way that checks are defined -- hopefully it's much easier now, but take a look at |
bruxisma
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jan 8, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.213` -> `^0.0.214` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.214`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.214) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.213...v0.0.214) #### What's Changed - Use text in comment token by [@​harupy](https://togithub.com/harupy) in [https://github.com/charliermarsh/ruff/pull/1714](https://togithub.com/charliermarsh/ruff/pull/1714) - Implement flake8-simplify SIM103 by [@​messense](https://togithub.com/messense) in [https://github.com/charliermarsh/ruff/pull/1712](https://togithub.com/charliermarsh/ruff/pull/1712) - Implement autofix for PT009 by [@​harupy](https://togithub.com/harupy) in [https://github.com/charliermarsh/ruff/pull/1713](https://togithub.com/charliermarsh/ruff/pull/1713) - Trim trailing whitespace when extracting isort directives by [@​harupy](https://togithub.com/harupy) in [https://github.com/charliermarsh/ruff/pull/1715](https://togithub.com/charliermarsh/ruff/pull/1715) - Introduce Violation trait by [@​not-my-profile](https://togithub.com/not-my-profile) in [https://github.com/charliermarsh/ruff/pull/1685](https://togithub.com/charliermarsh/ruff/pull/1685) - Update CONTRIBUTING.md to point to violations.rs by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1720](https://togithub.com/charliermarsh/ruff/pull/1720) - flake8\_simplify : SIM210, SIM211, SIM212 by [@​chammika-become](https://togithub.com/chammika-become) in [https://github.com/charliermarsh/ruff/pull/1717](https://togithub.com/charliermarsh/ruff/pull/1717) **Full Changelog**: astral-sh/ruff@v0.0.213...v0.0.214 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuODQuMiJ9--> Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
charliermarsh
pushed a commit
that referenced
this pull request
Jan 8, 2023
bug-fix in #1717 Use the correct `IfExprWithTwistedArms` struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements few Checks/Fixes for #998
@charliermarsh please review and let me know any improvements