Add user_configuration_directory to System
#16020
Merged
+183
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
internal
MichaReiser
requested review from
carljm,
AlexWaygood and
sharkdp
as code owners
MichaReiser
force-pushed
the
micha/system-user-configurationd-directory
branch
2 times, most recently
from
50e15b4 to
6b78710
Compare
|
sharkdp
reviewed
Feb 10, 2025
sharkdp
reviewed
Feb 10, 2025
MichaReiser
force-pushed
the
micha/system-user-configurationd-directory
branch
from
6b78710 to
902cdb4
Compare
dcreager
added a commit
that referenced
this pull request
Feb 11, 2025
* main: add diagnostic `Span` (couples `File` and `TextRange`) (#16101) Remove `Hash` and `Eq` from `AstNodeRef` for types not implementing `Eq` or `Hash` (#16100) Fix release build warning about unused todo type message (#16102) [`pydocstyle`] Handle arguments with the same names as sections (`D417`) (#16011) [red-knot] Reduce usage of `From<Type>` implementations when working with `Symbol`s (#16076) Transition to salsa coarse-grained tracked structs (#15763) [`pyupgrade`] Handle micro version numbers correctly (`UP036`) (#16091) [red-knot] `T | object == object` (#16088) [`ruff`] Skip singleton starred expressions for `incorrectly-parenthesized-tuple-in-subscript` (`RUF031`) (#16083) Delete left-over `verbosity.rs (#16081) [red-knot] User-level configuration (#16021) Add `user_configuration_directory` to `System` (#16020)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
user_configuration_directorymethod toSystem. We need it to resolve where to lookup a user-levelknot.tomlconfiguration file.The method belongs to
Systembecause not all platforms have a convention of where to store such configuration files (e.g. wasm).I refactored
TestSystemto be a simple wrapper around anArc<dyn System...>and use theSystem.as_anymethod instead to cast it down to anInMemorysystem. I also removed someSystemspecific methods fromInMemoryFileSystem, they don't belong there.This PR removes the
osfeature as a default feature fromruff_db. Most crates depending onruff_dbdon't need it because they only depend onSystemor only depend onosfor testing. This was necessary to fix a compile error withred_knot_wasmTest Plan
I'll make use of the method in my next PR. So I guess we won't know if it works before then but I copied the code from Ruff/uv, so I have high confidence that it is correct.
cargo test