Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airflow] BashOperator has been moved to airflow.providers.standard.operators.bash.BashOperator (AIR302) #15922

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Feb 4, 2025

Summary

Extend AIR302 with

  • airflow.operators.bash.BashOperator → airflow.providers.standard.operators.bash.BashOperator
  • change existing rules airflow.operators.bash_operator.BashOperator → airflow.operators.bash.BashOperator to airflow.operators.bash_operator.BashOperator → airflow.providers.standard.operators.bash.BashOperator

Test Plan

a test fixture has been updated

@Lee-W Lee-W changed the base branch from extend-AIR302 to main February 4, 2025 07:24
@Lee-W Lee-W changed the title Extend air302 [airflow] BashOperator has been moved to airflow.providers.standard.operators.bash.BashOperator (AIR302) Feb 4, 2025
@Lee-W Lee-W closed this Feb 4, 2025
@Lee-W Lee-W reopened this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+3 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

apache/airflow (+3 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ performance/src/performance_dags/performance_dag/performance_dag.py:95:13: AIR302 `airflow.operators.bash.BashOperator` is removed in Airflow 3.0
+ providers/edge/src/airflow/providers/edge/example_dags/integration_test.py:115:24: AIR302 `airflow.operators.bash.BashOperator` is removed in Airflow 3.0
+ tests/decorators/test_bash.py:521:13: AIR302 `airflow.operators.bash.BashOperator` is removed in Airflow 3.0

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
AIR302 3 3 0 0 0

@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule preview Related to preview mode features labels Feb 4, 2025
@dhruvmanila dhruvmanila merged commit de4d997 into astral-sh:main Feb 4, 2025
21 checks passed
dcreager added a commit that referenced this pull request Feb 4, 2025
* main: (66 commits)
  [red-knot] Use ternary decision diagrams (TDDs) for visibility constraints (#15861)
  [`pyupgrade`] Rename private type parameters in PEP 695 generics (`UP049`) (#15862)
  Simplify the `StringFlags` trait (#15944)
  [`flake8-pyi`] Make `PYI019` autofixable for `.py` files in preview mode as well as stubs (#15889)
  Docs (`linter.md`): clarify that Python files are always searched for in subdirectories (#15882)
  [`flake8-pyi`] Make PEP-695 functions with multiple type parameters fixable by PYI019 again (#15938)
  [red-knot] Use unambiguous invalid-syntax-construct for suppression comment test (#15933)
  Make `Binding::range()` point to the range of a type parameter's name, not the full type parameter (#15935)
  Update black deviations (#15928)
  [red-knot] MDTest: Fix line numbers in error messages (#15932)
  Preserve triple quotes and prefixes for strings (#15818)
  [red-knot] Hand-written MDTest parser (#15926)
  [`pylint`] Fix missing parens in unsafe fix for `unnecessary-dunder-call` (`PLC2801`) (#15762)
  nit: docs for ignore & select (#15883)
  [airflow] `BashOperator` has been moved to `airflow.providers.standard.operators.bash.BashOperator` (AIR302) (#15922)
  [`flake8-logging`] `.exception()` and `exc_info=` outside exception handlers (`LOG004`, `LOG014`) (#15799)
  [red-knot] Enforce specifying paths for mdtest code blocks in a separate preceding line (#15890)
  [red-knot] Internal refactoring of visibility constraints API (#15913)
  [red-knot] Implicit instance attributes (#15811)
  [`flake8-comprehensions`] Handle extraneous parentheses around list comprehension (`C403`) (#15877)
  ...
dhruvmanila pushed a commit that referenced this pull request Feb 7, 2025
…r}` for `AIR302` (#16014)

## Summary

Apply suggestions similar to
#15922 (comment)


## Test Plan

a test fixture has been updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants