Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Clarify behavior when redeclaring base class attributes #15826

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[red-knot] Clarify behavior when redeclaring base class attributes #15826

merged 1 commit into from
Jan 30, 2025

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Jan 30, 2025

Summary

Clarify the behavior regarding re-declaration of attributes from base classes following this discussion

@sharkdp sharkdp added the red-knot Multi-file analysis & type inference label Jan 30, 2025
@sharkdp sharkdp mentioned this pull request Jan 30, 2025
Merged
AlexWaygood
AlexWaygood approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sharkdp sharkdp merged commit 451f251 into main Jan 30, 2025
21 checks passed
@sharkdp sharkdp deleted the david/redeclaring-base-class-attributes branch January 30, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkdp @AlexWaygood