Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f-string formatting to the docs #15367

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Conversation

dhruvmanila
Copy link
Member

Revive #15341 as it got removed from the latest rebase in #15238.

@dhruvmanila dhruvmanila added the documentation Improvements or additions to documentation label Jan 9, 2025
@MichaReiser
Copy link
Member

Huh weird. I used --force-with-lease. Sorry for that. I assume there are no new changes that need reviewing. I suggest to just merge it.

@dhruvmanila dhruvmanila merged commit 97d95da into ruff-0.9 Jan 9, 2025
20 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/f-string-docs branch January 9, 2025 07:56
@dhruvmanila
Copy link
Member Author

24e45aa is a new commit which just adds a reference to quote-style setting in various places.

MichaReiser pushed a commit that referenced this pull request Jan 9, 2025
Revive #15341 as it got removed
from the latest rebase in #15238.
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Sorry I didn't get a chance to look properly before the release earlier

Comment on lines +430 to +432
f'{"""nested " """}'`
# This f-string cannot be formatted as follows when targeting Python < 3.12
f"{'''nested " '''}``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, what's with the backticks at the end of line 430 and 432?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks! They're totally not expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants