[flake8-pyi] Stabilize: include all python file types for PYI006

[MichaReiser]

Summary

Stabilizes the behavior changes introduced in #14059

PYI006 and PYI066 now also apply to non stub files.

Test plan

There are no open or recently closed issues around PYI006 or PYI066

[MichaReiser]

The diff here looks misleading. All I did is to remove the outermost if

[github-actions]

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

pytest-dev/pytest (+1 -0 violations, +0 -0 fixes)

+ testing/_py/test_local.py:21:12: PYI006 Use `<` or `>=` for `sys.version_info` comparisons

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
PYI006	1	1	0	0	0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -4 violations, +0 -0 fixes in 2 projects; 53 projects unchanged)

apache/airflow (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- airflow/decorators/condition.py:32:35: TC008 [*] Remove quotes from type alias
- airflow/decorators/condition.py:33:35: TC008 [*] Remove quotes from type alias

latchbio/latch (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

- src/latch/ldata/_transfer/upload.py:30:32: TC008 [*] Remove quotes from type alias
- src/latch/ldata/_transfer/upload.py:31:35: TC008 [*] Remove quotes from type alias

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
TC008	4	0	4	0	0

[MichaReiser]

I'd like to have a second opinion on a few ecosystem results. There are instances where the sys.version check is part of an and or or condition. Should the rule still apply in those cases?

• https://github.com/pytest-dev/pytest/blob/5d58b1fa7822fb1b8ff28cacc8a3c37e521e5cc3/src/_pytest/_code/code.py#L707
• https://github.com/scikit-build/scikit-build-core/blob/241c63bcec484b63f1c9d95eb696414cfc02f6c8/tests/test_builder.py#L247

Rewriting some of those just feels slightly more awkward

[AlexWaygood]

I'd like to have a second opinion on a few ecosystem results. There are instances where the sys.version check is part of an and or or condition. Should the rule still apply in those cases?

That's a great catch. No, I don't think it should apply in those cases. Let's hold off on stabilising the PYI066 change, in that case.

[MichaReiser]

I created an issue to follow up on PYI066 (#15347) and are about to roll back the PYI066 changes

[AlexWaygood]

Thank you!