[red-knot] Report invalid exceptions #15042
Merged
+177
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InSyncWithFoo
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
|
carljm
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Nice! This looks good to me.
I'd like to get @AlexWaygood review on it, since he's done most of the work on exceptions so far. Feel free to hold off on implementing my comments until he reviews also.
crates/red_knot_python_semantic/resources/mdtest/exception/basic.md
Outdated
Show resolved
Hide resolved
MichaReiser
reviewed
Dec 18, 2024
MichaReiser
reviewed
Dec 18, 2024
AlexWaygood
requested changes
Dec 18, 2024
AlexWaygood
reviewed
Dec 18, 2024
InSyncWithFoo
force-pushed
the
rk-exceptions
branch
from
d72a3e8 to
099f758
Compare
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
reviewed
Dec 18, 2024
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #15038.
Test Plan
Markdown tests.