[red-knot] Explicitly test diagnostics are emitted for unresolvable submodule imports #15035
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
requested review from
carljm,
MichaReiser and
sharkdp
as code owners
|
dcreager
added a commit
that referenced
this pull request
Dec 17, 2024
* main: [red-knot] Explicitly test diagnostics are emitted for unresolvable submodule imports (#15035) Fix stale File status in tests (#15030) [red-knot] Basic support for other legacy `typing` aliases (#14998) feat(AIR302): extend the following rules (#15015) [`perflint`] Simplify finding the loop target in `PERF401` (#15025) [red-knot] Avoid undeclared path when raising conflicting declarations (#14958)
T-256
reviewed
Dec 17, 2024
| import a.foo # error: [unresolved-import] "Cannot resolve import `a.foo`" | ||
|
|
||
| # Topmost component unresolvable: | ||
| import b.foo # error: [unresolved-import] "Cannot resolve import `b.foo`" |
There was a problem hiding this comment.
IMO, this message could mention only b. it'd improve discoverability when debugging.
There was a problem hiding this comment.
Yeah, there's definitely room for improvement here. I mainly wanted to add a test that made sure that we emitted a diagnostic on both of these (because I nearly proposed a refactor that would have accidentally made that not-the-case, and no tests failed on my bad patch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything's working as expected here, but we didn't have explicit tests for these; this PR just adds some missing cases