[red-knot] Move the ClassBase enum to its own submodule
#14957
Merged
+181
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
internal
AlexWaygood
requested review from
carljm,
MichaReiser and
sharkdp
as code owners
|
AlexWaygood
force-pushed
the
alex/move-class-base
branch
from
0949b06 to
6e4e09e
Compare
MichaReiser
approved these changes
Dec 13, 2024
dcreager
added a commit
that referenced
this pull request
Dec 13, 2024
* main: [red-knot] Display definition range in trace logs (#14955) [red-knot] Move the `ClassBase` enum to its own submodule (#14957) [red-knot] mdtest: python version requirements (#14954) [airflow]: Import modules that has been moved to airflow providers (AIR303) (#14764) [red-knot] Support `typing.TYPE_CHECKING` (#14952) Add tracing support to mdtest (#14935) Re-enable the fuzzer job on PRs (#14953) [red-knot] Improve `match` mdtests (#14951) Rename `custom-typeshed-dir`, `target-version` and `current-directory` CLI options (#14930) [red-knot] Add narrowing for 'while' loops (#14947) [`ruff`] Skip SQLModel base classes for `mutable-class-default` (`RUF012`) (#14949) [red-knot] Tests for 'while' loop boundness (#14944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This enum is no longer an implementation detail of how we infer the MROs of classes, so it no longer feels appropriate for it to live in
mro.rs. It's not very big right now, so we could move it intotypes.rs. However, I think our general feeling is thattypes.rsandinfer.rsare both already a little too big, and I also expect this enum to continue to grow as we add support for more special forms and generics. This PR therefore moves the enum to its own submodule,class_base.rs.Test Plan
All existing tests pass. No new ones are added; this is a pure refactor with no behavioural changes.