Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] Ignore overload in PLR0904 #14730

Conversation

Matt-Ord
Copy link
Contributor

@Matt-Ord Matt-Ord commented Dec 2, 2024

Fixes #14727

Summary

Fixes #14727

Test Plan

cargo test

Copy link
Contributor

github-actions bot commented Dec 2, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+6 -10 violations, +0 -0 fixes in 5 projects; 50 projects unchanged)

PlasmaPy/PlasmaPy (+0 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- src/plasmapy/particles/particle_collections.py:56:1: PLR0904 Too many public methods (21 > 20)

apache/airflow (+4 -4 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/configuration.py:184:1: PLR0904 Too many public methods (40 > 20)
- airflow/configuration.py:184:1: PLR0904 Too many public methods (42 > 20)
+ airflow/models/dag.py:307:1: PLR0904 Too many public methods (40 > 20)
- airflow/models/dag.py:307:1: PLR0904 Too many public methods (42 > 20)
+ providers/src/airflow/providers/common/sql/hooks/sql.py:102:1: PLR0904 Too many public methods (32 > 20)
- providers/src/airflow/providers/common/sql/hooks/sql.py:102:1: PLR0904 Too many public methods (34 > 20)
+ providers/src/airflow/providers/google/cloud/hooks/gcs.py:150:1: PLR0904 Too many public methods (27 > 20)
- providers/src/airflow/providers/google/cloud/hooks/gcs.py:150:1: PLR0904 Too many public methods (29 > 20)

bokeh/bokeh (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- src/bokeh/core/has_props.py:244:1: PLR0904 Too many public methods (24 > 20)
- src/bokeh/models/plots.py:115:1: PLR0904 Too many public methods (21 > 20)

ibis-project/ibis (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ ibis/expr/types/relations.py:144:1: PLR0904 Too many public methods (61 > 20)
- ibis/expr/types/relations.py:144:1: PLR0904 Too many public methods (63 > 20)

pytest-dev/pytest (+1 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/_pytest/_py/path.py:265:1: PLR0904 Too many public methods (66 > 20)
- src/_pytest/_py/path.py:265:1: PLR0904 Too many public methods (68 > 20)
- src/_pytest/nodes.py:128:1: PLR0904 Too many public methods (22 > 20)

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLR0904 16 6 10 0 0

@charliermarsh charliermarsh added the bug Something isn't working label Dec 2, 2024
@charliermarsh charliermarsh changed the title Ignore overload in PLR0904 [pylint] Ignore overload in PLR0904 Dec 2, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) December 2, 2024 14:33
@charliermarsh charliermarsh merged commit 83651de into astral-sh:main Dec 2, 2024
20 checks passed
@Matt-Ord Matt-Ord deleted the Ignore-overloads-in-too-many-public-methods branch December 2, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLR0904: false positive when using overload
2 participants