Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] Fix false negatives for ascii and sorted in len-as-condition (PLC1802) #14692

Merged
merged 1 commit into from
Nov 30, 2024
Merged

[pylint] Fix false negatives for ascii and sorted in len-as-condition (PLC1802) #14692

merged 1 commit into from
Nov 30, 2024

Conversation

sbrugman
Copy link
Contributor

@sbrugman sbrugman commented Nov 30, 2024 •
edited
Loading

Summary

Fixes #14690.

Test Plan

Added test cases.

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

dylwil3
dylwil3 approved these changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dylwil3 dylwil3 added the rule Implementing or modifying a lint rule label Nov 30, 2024
@dylwil3 dylwil3 merged commit 56ae73a into astral-sh:main Nov 30, 2024
21 checks passed
@sbrugman sbrugman deleted the PLC1802-false-negatives branch November 30, 2024 20:18
@MichaReiser MichaReiser mentioned this pull request Dec 2, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylwil3 dylwil3 dylwil3 approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PLC1802 has false negatives for ascii and sorted
2 participants
@sbrugman @dylwil3