[red-knot] Cleanup some KnownClass
APIs
#14269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KnownClass::to_class
toKnownClass::to_class_literal
. This is an oversight that should have been done as part of [red-knot] Introduce a newClassLiteralType
struct #14108.to
KnownClass::try_from_module`. I think this fits better with typical Rust naming conventions.KnownClass::from_name
. I don't think it would ever produce desirable results if you called this method from outside ofKnownClass::try_from_module
(because you also need to check which module the class is coming from, for correctness), so inlining it seems best here.CoreStdlibModule
enum inred_knot_python_semantic/src/stdlib.rs
to reduce code duplication and reduce hardcoded strings.Test Plan
cargo test -p red_knot_python_semantic