Use operator specific messaging in division by zero diagnostics #13588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Oct 1, 2024
| "Cannot divide object of type 'Literal[2]' by zero.", | ||
| "Cannot divide object of type 'Literal[3]' by zero.", | ||
| "Cannot floor divide object of type 'Literal[2]' by zero.", | ||
| "Cannot reduce object of type 'Literal[3]' modulo zero.", |
There was a problem hiding this comment.
This is the most consistent language I can find for this online.
There was a problem hiding this comment.
could possibly do something like this, but it's annoyingly verbose:
Suggested change
| "Cannot reduce object of type 'Literal[3]' modulo zero.", | |
| "Using modulo with a zero divisor is undefined on an object of type 'Literal[3]'.", |
There was a problem hiding this comment.
Yeah that seems too verbose to me and differs quite a bit from the other messages.
There was a problem hiding this comment.
I think what you have now is fine!
|
AlexWaygood
approved these changes
Oct 1, 2024
| "Cannot divide object of type 'Literal[2]' by zero.", | ||
| "Cannot divide object of type 'Literal[3]' by zero.", | ||
| "Cannot floor divide object of type 'Literal[2]' by zero.", | ||
| "Cannot reduce object of type 'Literal[3]' modulo zero.", |
There was a problem hiding this comment.
could possibly do something like this, but it's annoyingly verbose:
Suggested change
| "Cannot reduce object of type 'Literal[3]' modulo zero.", | |
| "Using modulo with a zero divisor is undefined on an object of type 'Literal[3]'.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested at #13576 (comment)