Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] visit with-item vars even if not a Name #13409

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Sep 19, 2024

This fixes the last panic on checking pandas.

(Match statement became an if let because clippy decided it wanted that once I added the additional line in the else case?)

Copy link
Member

@AlexWaygood AlexWaygood Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should see if we can setup a test that runs on all the test Python snippets we have for the parser as well. We have very extensive parser coverage for with statements; it would have caught this :-)

crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Sep 19, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@carljm carljm merged commit 260c2ec into main Sep 19, 2024
20 checks passed
@carljm carljm deleted the cjm/with-non-name branch September 19, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants