Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] - remove AugAssign errors from self-cls-assignment (W0642) #12957

Merged
merged 3 commits into from
Aug 18, 2024
Merged

[pylint] - remove AugAssign errors from self-cls-assignment (W0642) #12957

merged 3 commits into from
Aug 18, 2024

Conversation

diceroll123
Copy link
Contributor

Summary

Fixes #12954

Test Plan

cargo test

AlexWaygood
AlexWaygood reviewed Aug 17, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

crates/ruff_linter/resources/test/fixtures/pylint/self_or_cls_assignment.py Show resolved Hide resolved
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #12957 will not alter performance

Comparing diceroll123:remove-augassign-from-plw0642 (f982598) with main (900e98b)

Summary

✅ 32 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 17, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood added bug Something isn't working rule Implementing or modifying a lint rule labels Aug 18, 2024
@AlexWaygood AlexWaygood enabled auto-merge (squash) August 18, 2024 15:27
@AlexWaygood AlexWaygood merged commit 4881d32 into astral-sh:main Aug 18, 2024
19 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
bug Something isn't working rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PLW0642 flags inplace operators called on self
2 participants
@diceroll123 @AlexWaygood