-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ruff
] Reduce FastAPI false positives in unused-async
(RUF029
)
#12938
[ruff
] Reduce FastAPI false positives in unused-async
(RUF029
)
#12938
Conversation
CodSpeed Performance ReportMerging #12938 will not alter performanceComparing Summary
|
Thanks for the PR!
Sorry, I think I might have been confusing when I mentioned configuration options in #12925 (comment). I don't think we need a configuration option here specifically regarding whether fastAPI routes should be ignored by this rule or not; that seems way too specific. I would just ignore fastAPI routes unconditionally in this rule, without adding a new configuration option. |
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
RUF029 | 68 | 0 | 68 | 0 | 0 |
A004 | 2 | 0 | 2 | 0 | 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion about the option. Let's remove it.
1d3d8d5
to
d52206a
Compare
crates/ruff_linter/resources/test/fixtures/ruff/RUF029_fastapi.py
Outdated
Show resolved
Hide resolved
d52206a
to
047d6bf
Compare
047d6bf
to
dab4e12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ruff
] Reduce FastAPI false positives in unused-async
(RUF029
)
review comments were addressed
Summary
Fixes #12925.