[flake8-async] Do not lint yield in context manager cancel-scope-no-checkpoint (ASYNC100)
#12896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MichaReiser
reviewed
Aug 14, 2024
| // in the caller yielded to. | ||
| // https://flake8-async.readthedocs.io/en/latest/rules.html#async100 | ||
| // https://github.com/astral-sh/ruff/issues/12873 | ||
| if with_stmt.body.iter().any(|stmt| { |
There was a problem hiding this comment.
The logic here only traverses the direct children of a with statement but, for example, not the statements in an if body. Is this intentional? If not, consider using the StatementVisitor
There was a problem hiding this comment.
Not intentional, thank you! I tried using any_over_body instead. Unless I'm misunderstanding, that's slightly faster since it gets to stop traversing the tree as soon as a yield is found, right?
There was a problem hiding this comment.
I'm not familiar with that method. I'll take a look tomorrow
There was a problem hiding this comment.
Yup, correct usage of any_over_body!
charliermarsh
force-pushed
the
async100-skip-yield-in-context-manager
branch
from
6f646d2 to
faf47ae
Compare
charliermarsh
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with upstream, treat
yieldas a checkpoint inside cancel scopes.Closes #12873.