Select stable import name when multiple possible bindings are in scope #12888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
changed the title
|
|
Tests pass on 32bit architectures: https://gitlab.alpinelinux.org/WhyNotHugo/aports/-/pipelines/252939 Some of the more exotic architectures are not done, but this does fix #12885 |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Aug 15, 2024
Also skip benchmark tests. See: astral-sh/ruff#12662 Includes: astral-sh/ruff#12888
|
@charliermarsh any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12885
The issue with the
FURB177test is that there are two viable bindings forpathlib.Path:pathlib.PathorPathbutbindingsis aHashMapthat has no guaranteed iteration order.I'm reluctant to change
bindingsto aBTreeMap. I would suspect that it comes with quiet a performance penalty. That's why this PR fixes this issue locallyby sorting the imports by their range and picking the last import if multiple options exist.
Test Plan
cargo testAlternatives
Split the test into two files. One that uses
import pathliband one withfrom pathlib import Path