Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refurb] - fix unused autofix for implicit-cwd (FURB177) #12708

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

diceroll123
Copy link
Contributor

Summary

The autofix for this already existed, it just was not pushed to the checker.

Test Plan

cargo test

Copy link
Contributor

github-actions bot commented Aug 6, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

I wondered if there was a reason for not pushing the fix, but nope. Has been like this since the rule was added.

Thanks for PRing the fix to add the right diagnostic ;)

@MichaReiser MichaReiser added the fixes Related to suggested fixes for violations label Aug 6, 2024
@MichaReiser MichaReiser merged commit 39dd732 into astral-sh:main Aug 6, 2024
20 checks passed
dylwil3 pushed a commit to dylwil3/ruff that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants